Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.0.7

Request #17678 various optimisations for speed
Submitted: 2010-08-09 19:54 UTC
From: kguest Assigned: bate
Status: Closed Package: Net_DNS (version SVN)
PHP Version: 5.2.6 OS:
Roadmaps: (Not assigned)    

 [2010-08-09 19:54 UTC] kguest (Ken Guest)
Description: ------------ Net_DNS wasn't quite quick enough so I've added some optimisations plus upgraded most of the ereg* functions to preg* considering they are now deprecated in php 5.3.*


 [2010-08-09 19:54 UTC] kguest (Ken Guest)
 [2010-08-09 20:14 UTC] bate (Marco Kaiser)
-Status: Open +Status: Closed -Assigned To: +Assigned To: bate
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on by the end of next Sunday (CET). If this was a problem with the website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. please test and report issues
 [2010-08-09 21:32 UTC] mikepultz (Mike Pultz)
FYI- all of these ereg to preg fixes were included in the patch I sent yesterday. The missing delimiters in TSIG.php breaks the feature in 1.0.2- a new release should probably be cut. I guess you're not actually patching the files, but manually making the changes from the diff?
 [2010-08-09 21:34 UTC] bate (Marco Kaiser)
i patched manual because the diff maked here more probs .. i release a new version
 [2010-08-10 13:45 UTC] kguest (Ken Guest)
-Status: Closed +Status: Open
patch file was from an $svn diff I ran yesterday prior to submitting it - hadn't pulled down the recent most versions before I generated it. not all of the optimisations in the patch I submitted have made it into the repo - the second use of $this->sleep in the resolver class for example as well as some of the simple value caching that is included in my patch. some of the new class level variable definitions are also missing - for $sleep and $parsedfiles. There are also optimisations missing from DNS/Packet.php. Not all occurrances of ereg have been phased out: [ken@clancy Net]$ svn update At revision 302065. [ken@clancy Net]$ find . -name \*php | xargs grep ereg ./DNS/RR/MX.php: ereg("([0-9]+)[ \t]+(.+)[ \t]*$", $data, $regs); ./DNS/RR/SOA.php: if (ereg("([^ \t]+)[ \t]+([^ \t]+)[ \t]+([0-9]+)[ \t]+([0-9]+)[ \t]+([0-9]+)[ \t]+([0-9]+)[ \t]+([0-9]+)[ \t]*$", $data, $regs)) ./DNS/RR/TXT.php: ereg('("[^"]*"|[^ \t]*)[ \t]*$', $data, $regs); ./DNS/RR/NAPTR.php: ereg('([0-9]+)[ \t]+([0-9]+)[ \t]+("[^"]*"|[^ \t]*)[ \t]+("[^"]*"|[^ \t]*)[ \t]+("[^"]*"|[^ \t]*)[ \t]+(.*?)[ \t]*$', $data, $regs); ./DNS/RR/SRV.php: ereg("([0-9]+)[ \t]+([0-9]+)[ \t]+([0-9]+)[ \t]+(.+)[ \t]*$", $data, $regs); ./DNS/Resolver.php: if (ereg("^[ \t]*$", $line, $regs)) { I will attach a revised patch file to include what is currently missing from the repo.
 [2010-08-10 13:46 UTC] kguest (Ken Guest)
 [2010-08-10 13:59 UTC] bate (Marco Kaiser)
-Status: Assigned +Status: Closed
Thank you for your bug report. This issue has been fixed in the latest released version of the package, which you can download at