Vote Details for "Text_Highlighter" by mansion

» Details
  • Voter: Bertrand Mansion 
  • Vote: +1 (conditional)
  • Reviews: Cursory source review, Deep source review, Run examples
» Comment
IMO, Some things still need to be fixed:

- If end attribute is empty (end=""), generator says: Uninitialized string offset: 0 in /usr/lib/php/Text/Highlighter/Generator.php on line 242

- undefined variable index line 63 (in generate tool) on every run

- I also had some undefined index defcolor line 240 and 420 but I don't remember how (sorry...)

- In js highlighter, I think case should be set to "no"

- I still get <ol> tags in the result when using numbers=true, beside the new table with the numbers, that makes 2 cols of numbers (a bit too much ;) )

Otherwise, it is working great, my Objective-C highlighter is ready.